Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: add a variable tidb_slow_log_threshold to set the slow log threshold dynamically (#8094) #8173

Merged
merged 2 commits into from
Nov 5, 2018
Merged

*: add a variable tidb_slow_log_threshold to set the slow log threshold dynamically (#8094) #8173

merged 2 commits into from
Nov 5, 2018

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Nov 5, 2018

What problem does this PR solve?

Cherry-pick #8094 to release 2.1.

PTAL @XuHuaiyu @lysu

@jackysp jackysp added type/enhancement The issue or PR belongs to an enhancement. type/2.1 cherry-pick labels Nov 5, 2018
@lysu
Copy link
Contributor

lysu commented Nov 5, 2018

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

lysu
lysu reviewed Nov 5, 2018
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XuHuaiyu
XuHuaiyu approved these changes Nov 5, 2018
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed labels Nov 5, 2018
@jackysp jackysp merged commit 15c5ee2 into pingcap:release-2.1 Nov 5, 2018
@jackysp jackysp deleted the slow_threshold_2.1 branch November 27, 2018 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysu lysu lysu left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackysp @lysu @XuHuaiyu @zz-jason